Comment From: swamymavuri
Thanks for the review comments @onobc , Updated the code as per review comments, please take a look once
Also can you suggest 1. whether do i need to raise a PR from my fork to your Branch(fork --> your branch --> Spring boot Main Branch), or for this feature, we can leave it as it is(from my fork -> Spring Boot Main Branch). 2. Do we need to reach out any one for review this PR from spring boot Thanks
Comment From: onobc
Also can you suggest
whether do i need to raise a PR from my fork to your Branch(fork --> your branch --> Spring boot Main Branch), or for this feature, we can leave it as it is(from my fork -> Spring Boot Main Branch).
We typically follow the fork-and-branch-git-workflow. The only difference w/ yours is that instead of doing your changes in origin/main you would create a userbranch such as origin/gh-38559-pulsar-auto-failover (or whatever name you choose) and then use that to submit the PR. Whatever you do, do not resubmit an entire new PR as that will cause a bunch of noise and we would lose the current comments etc.. @philwebb what is the preferred action in this case?
Do we need to reach out any one for review this PR from spring boot
Nope. Trust me, the team sees the PR and are just very busy - but they will get to the PR.
Comment From: mhalbritter
Thank you very much and congratulations on your first contribution :tada:!
Comment From: swamymavuri
Thanks @mhalbritter