This PR only changes the indents in the README.adoc file because the current rendering looks weird on GitHub. The following images show the difference. I am using macOS Monterey 12.1 and Google Chrome 97.
Edit: Added screenshots (before, after)
Comment From: wilkinsona
Thanks for the PR. Other than tabs vs spaces (we prefer tabs), the indentation looks the same to me as what we currently have. Can you share some more details about how it looks weird to you, perhaps a screenshot and details of the browser that you're using?
Comment From: itsandreramon
Hey Andy, thanks for the quick response. I added two images (before, after) to the initial PR comment.
Comment From: philwebb
@itsandreramon What OS and web browser are you using?
Comment From: itsandreramon
I added the requested information at the top!
Comment From: philwebb
Thanks for the additional info @itsandreramon
I'd like to keep the README file using tabs since I think it's more accessible. The good news is that I discovered GitHub has a setting that you can use to tweak the tab width. Take a look at this blog post. Changing "Tab size preference" to 4 in my appearance settings makes things look better.
Comment From: vpavic
FWIW @philwebb, I've had the Tab size preference setting set to 4 ever since the GitHub introduced the setting but I don't think that applies to the code snippets inside files that are otherwise plain text.
This is what it looks like for me in Firefox on Ubuntu:
Comment From: philwebb
Ohh, that's really annoying. I still feel like we should keep tabs in the README files. I wonder if wonder if GitHub might fix that sometime in the future? Looks like there are some extensions that might also work around the issue (e.g. https://addons.mozilla.org/en-US/firefox/addon/github-tab-render-size)
Comment From: mahozad
@philwebb
I wanted to create a PR and "fix" the weird indentation. I found this PR. From two years ago...
Could you please change from tabs to spaces in this code snippet?
Comment From: wilkinsona
I'm afraid not. Accessibility is as important to use now as it was two years ago so we want to continue using tabs.