I think it's possible to return true/false values even without a 'match' variable. Also, I think readability can be improved with early return.
Comment From: wilkinsona
WDYT, @philwebb? The approach of reassigning match rather than returning early seems to have been introduced in https://github.com/spring-projects/spring-boot/commit/516df88ea042b0b6de64c33b85c8b0b0ed0fe760.
Comment From: philwebb
I think we have a few places where we use a variable like this to reduce the amount of code. I think we use it quite a bit in equals methods. I don't think there's a real performance or memory impact and the readability is somewhat subjective so I'd be inclined to keep the code as it is.
Thanks anyway for the suggestion.