The Arrays.asList method creates a List based on variable arguments, which can lead to heap pollution. azureEnvVariables is an immutable field, so it has been improved to utilize Immutable List.

Comment From: pivotal-cla

@smc2315 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Comment From: pivotal-cla

@smc2315 Thank you for signing the Contributor License Agreement!

Comment From: quaff

There are ubiquitous Arrays.asList(), I'll try replace them all and add checkstyle rule to guard that.

Comment From: wilkinsona

Thanks for the PR but we considered such a change in the past and decided against it.