Comment From: pivotal-cla
@Chu3laMan Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@Chu3laMan Thank you for signing the Contributor License Agreement!
Comment From: Chu3laMan
Thanks for the PR, @Chu3laMan. I've left a few comments for you to consider when you have a minute.
Thank you for your remarks, do not we need to handle error during logout phase in the same function?
Comment From: mhalbritter
do not we need to handle error during logout phase in the same function?
I'm not sure I don't understand - what exactly do you mean?
Comment From: mhalbritter
I merged the PR - thank you very much and congratulations on your first contribution :tada:!
Comment From: Chu3laMan
do not we need to handle error during logout phase in the same function?
I'm not sure I don't understand - what exactly do you mean?
I mean during the logout session, if an error occurred, don't we need to handle it via a custom event?
Comment From: Chu3laMan
I merged the PR - thank you very much and congratulations on your first contribution 🎉!
I really appreciate it, Thank you @philwebb , @wilkinsona, and @mhalbritter
Comment From: mhalbritter
do not we need to handle error during logout phase in the same function?
I'm not sure I don't understand - what exactly do you mean?
I mean during the logout session, if an error occurred, don't we need to handle it via a custom event?
This is all handled by Spring Security. This component in Boot only translates the Spring Security Events into audit events.