adding ability to specify active profiles in @JdbcTest, @DataJpaTest and @RestClientTest
this enhancement
Comment From: wilkinsona
Oops. I see now that it's not your first, we just haven't quite got to merging one yet. Thanks very much nonetheless.
Comment From: mbhave
We might also need to add the properties attribute for @WebMvcTest and @WebFluxTest.
Comment From: ayudovin
@wilkinsona ok, I agree with you and have updated code by your comment
Comment From: ayudovin
@mbhave, I have added this functionality for @WebMvcTest and @WebFluxTest following your comment. Thank you for advice.
Comment From: wilkinsona
This looks good now, @ayudovin. Thanks very much.
Comment From: ayudovin
@wilkinsona yeah, I'd like to do it but I have some questions : 1) Do i need to remove unnecessary unit tests from this pull request ? 2) How will be better : add this functionality for new annotation in this pull request or create new pull request for it?
Comment From: wilkinsona
Thanks. I think we can continue to do everything in this pull request.
Comment From: ayudovin
Ok, no problem, I’ll do it
Comment From: ayudovin
@wilkinsona, I have added this functionality for all annotations:
- @DataLdapTest
- @DataMongoTest
- @DataNeo4jTest
- @DataRedisTest
- @JooqTest
- @JsonTest
Comment From: wilkinsona
Thanks very much once again, @ayudovin. The proposed changes are now in master along with a little bit of polish.
@mbhave pointed out to me that we've already merged several pull requests from you so it's a bit annoying that GitHub still thinks you're a first-time contributor. Perhaps the email address you are using in the commits isn't one that's associated with your GitHub account?
Comment From: ayudovin
@wilkinsona thank you for merging. ok, I'll check my email address and try to fix it. I apologize for the inconvenience.