This commit adds configuration properties that allow users to configure number of IO threads and listener threads used by the Pulsar client.
From my experience with Pulsar, using these settings is often needed to achieve the optimal setup of the Pulsar client so ideally Spring Boot's auto-config would provide a way to do this using configuration properties.
/cc @onobc
Comment From: onobc
From my experience with Pulsar, using these settings is often needed to achieve the optimal setup of the Pulsar client so ideally Spring Boot's auto-config would provide a way to do this using configuration properties.
Thanks for the contribution @vpavic . When we brought the auto-configuration into Spring Boot we greatly reduced the number of configuration properties we supported. We wanted the community to let us know which properties were important. Thank you for doing that here. Let's see what the Boot team thinks.
Comment From: philwebb
It sounds like they'd be useful for a lot of apps so I'm in favor of adding them. I wonder if we should put them under a nested Threads class (similar to server.tomcat.thread.<name>)?
Comment From: onobc
It sounds like they'd be useful for a lot of apps so I'm in favor of adding them. I wonder if we should put them under a nested
Threadsclass (similar toserver.tomcat.thread.<name>)?
I think grouping them under thread would be a good forward-thinking idea. The naming here is interesting....
ioThreads->thread.num-ioorthread.io?listenerThreads->thread.num-listenerorthread.listener?
Comment From: philwebb
I would suggest something similar to existing tomcat ones. threads.io and threads.listener would be my suggestion.
Comment From: vpavic
I've updated the PR accordingly.
Comment From: philwebb
Thanks @vpavic! Merged into main.