Otlp Tracing's exporter is configured using Transport. Current support for service connections read the mapped port for HTTP transport 4318. This commits adds support to read port for GRPC transport 4317.
Comment From: wilkinsona
Thanks for the PR, @eddumelendez. I'm not sure what the answer is, but this doesn't feel quite right to me. I don't think the connection details should have a separate method for the GRPC endpoint. Ideally, the existing getUrl() method would return the URL that's appropriate for the configured transport but I'm not yet sure how we could achieve that.
Comment From: eddumelendez
Hi @wilkinsona, yes, I agree. I think that's the only way I was able to achieve it. Looking forward for any hint to update the PR.
Comment From: philwebb
We discussed this today and we think we might be able to pass the Transport to a OtlpTracingConnectionDetails.getUrl(...) method. We can experiment with this before we merge the PR.
Comment From: wilkinsona
Placing on hold as we'd like to spend a bit of time thinking through our gRPC support across logs, metrics, and tracing.
Comment From: mhalbritter
Thanks!
I've modified OtlpTracingConnectionDetails to add a String getUrl(Transport transport) method.