gh-34778

Comment From: nosan

The open question is about hazelcast/hazelcast-enterprise image, should I add it as well?

https://hub.docker.com/r/hazelcast/hazelcast-enterprise

You do not need to set a license key for your Java clients for which you want to use Hazelcast IMDG Enterprise features. Hazelcast IMDG Enterprise license keys are required only for members.

Comment From: mhalbritter

The open question is about hazelcast/hazelcast-enterprise image, should I add it as well?

https://hub.docker.com/r/hazelcast/hazelcast-enterprise

I can't start hazelcast/hazelcast-enterprise without setting an enterprise key.

com.hazelcast.license.exception.InvalidLicenseException: The Hazelcast Enterprise license key is not set.
To set the license key, please do one of the following:
  - Change member config using Java API: config.setLicenseKey("...")
  - Change XML/YAML configuration property: Set hazelcast.license-key: ...
  - Add system property: -Dhz.licensekey=... (for Hazelcast embedded, works only when loading config via Config.load)
  - Add environment variable: HZ_LICENSEKEY=... (recommended when running container image. For Hazelcast embedded, works only when loading config via Config.load)

You do not need to set a license key for your Java clients for which you want to use Hazelcast IMDG Enterprise features. Hazelcast IMDG Enterprise license keys are required only for members.

I think I don't understand this sentence. Does that mean I don't have to set the license key on the client which connects to the enterprise server?

Comment From: nosan

I think I don't understand this sentence. Does that mean I don't have to set the license key on the client which connects to the enterprise server?

Yes, you are right. You don't need to configure a client with a license key to connect to hazelcast-enterprise.

I can't start hazelcast/hazelcast-enterprise without setting an enterprise key.

I verified this locally (I have a license key).

I am asking because I understand that adding this image without a test does not sound right. I can add this image and test for it but in that case, HZ_LICENSEKEY should be configured on Spring Boot CI.

JUnit condition (EnabledIfEnvironmentVariable) as well.

Comment From: mhalbritter

Thanks for the clarification. I'll talk to the team about this.

Comment From: wilkinsona

I don't think we should add support for hazelcast-enterprise as we can't (easily) test it.

Comment From: nosan

Thank you very much for your review @mhalbritter I fixed your comments. I hope I did not mess with sorting.

Comment From: mhalbritter

Thanks @nosan !

Comment From: nosan

Thank you @mhalbritter