In #42589, we make ZipkinHttpClientSender the default sender. The conditions for that bean are:
@ConditionalOnClass(HttpClient.class)
@ConditionalOnMissingBean(BytesMessageSender.class)
that means on every JDK which has HttpClient in it (which should be most of them, unless you built a custom one with jlink), ZipkinHttpClientSender will be used.
Given that, I think we can remove URLConnectionSender, which needs the zipkin-sender-urlconnection dependency on the classpath.
Comment From: thecooldrop
Hi @mhalbritter , this seems like completed issue. Is there some work outstanding? If so, what would it be? I may be interessted in pushing the issue over into the "complete" category.
Comment From: nosan
Hi @thecooldrop,
This issue is still open.
Is there some work outstanding? If so, what would it be?
The SenderConfiguration in ZipkinConfigurations still imports UrlConnectionSenderConfiguration. The goal of this task is to remove this import and completely delete UrlConnectionSenderConfiguration. Additionally, update ZipkinConfigurationsSenderConfigurationTests and remove the io.zipkin.reporter2:zipkin-sender-urlconnection dependency from all locations.
Comment From: thecooldrop
Hi @thecooldrop,
This issue is still open.
Is there some work outstanding? If so, what would it be?
The
SenderConfigurationin ZipkinConfigurations still importsUrlConnectionSenderConfiguration. The goal of this task is to remove this import and completely deleteUrlConnectionSenderConfiguration. Additionally, updateZipkinConfigurationsSenderConfigurationTestsand remove theio.zipkin.reporter2:zipkin-sender-urlconnectiondependency from all locations.
Like this https://github.com/spring-projects/spring-boot/pull/44500 ? What I did is suspiciously simple to me.