Description

This PR have removed three SenderConfiguration also its Sender: UrlConnectionSenderConfiguration, RestTemplateSenderConfiguration and WebClientSenderConfiguration in file ZipkinConfigurations. Remove the related test cases about these SenderConfiguration class in file ZipkinConfigurationsSenderConfigurationTests.

Related Issue

Fixed #42589, #43047, #43048

Type of Change

  • [X] Remove feature
  • [X] Remove related tests
  • [ ] Add new test cases
  • [ ] Documentation update

Checklist

  • [X] I have reviewed the code for any potential issues or improvements.
  • [X] I have run tests locally and they are passing.
  • [X] I have followed the coding style and conventions of the project.

Screenshots

SpringBoot Remove deprecated ZipkinSender

Additional Notes

I does remove the other Senders and its SenderConfiguration class, and also remove the test class related to these deprecated🥰. But do I need refactor ZipkinConfiguration structure, and write some test case to integrate test this modified class.🤨 Also update the documents about this related Sender🤔. Please give me some advice if this PR can't be merged🥹, and I will try my best to fix it up. Looking forward to your reply❤️~

Comment From: wilkinsona

Thanks for the PR, @wickdynex. Unfortunately, this is changing too many different things for a single PR. Please just focus on the changes for #42589 as already described by @mhalbritter:

In the scope of this issue, you should just reorder the configurations, like you said in https://github.com/spring-projects/spring-boot/issues/42589#issuecomment-2450330858. And I guess some tests needs to be adapted.

Comment From: wickdynex

Thanks for the PR, @wickdynex. Unfortunately, this is changing too many different things for a single PR. Please just focus on the changes for #42589 as already described by @mhalbritter:

In the scope of this issue, you should just reorder the configurations, like you said in #42589 (comment). And I guess some tests needs to be adapted.

Alright, maybe I should split this PR into 3 pieces for 3 issues🤔? I feel sorry to deal many issues in a single PR, it makes code review difficult🥺. emmm, and how to deal with this PR, close or continually commit on this branch? do u have any idea?🥰 And also assign the issue #43047, #43048 to me? If I can fix it🥳.

Comment From: wilkinsona

how to deal with this PR, close or continually commit on this branch?

You can either:

  • replace the five commits on your remove-deprecated-zipkin-sender branch with a single commit that just contains the changes for #42589 and then force-push
  • close this PR an open a fresh one that contains a single commit focussed on #42589

And also assign the issue https://github.com/spring-projects/spring-boot/issues/43047, https://github.com/spring-projects/spring-boot/issues/43048 to me? If I can fix it🥳

One thing at a time please. Let's get a PR for #42589 into a state where it's ready to be merged before considering the other two issues.

Comment From: snicoll

I can see you created a new PR. closing this one

Comment From: wickdynex

I can see you created a new PR. closing this one

Yeah, thanks for your help🥳.