Object comparisons between all wrapper classes should use equals
Comment From: pivotal-issuemaster
@thenx-wei Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-issuemaster
@thenx-wei Thank you for signing the Contributor License Agreement!
Comment From: rstoyanchev
It is actually fine the way it is, and the compiler understands to unbox Boolean.True and compare the values. The test that proves it is here. Further, allowCredentials is a nullable field and this way of comparing protects against NPE.
The changes to ContentDisposition appear to be unrelated and inconsistent with our code style.
Comment From: PascalSchumacher
I guess this should be removed from the 5.2.4 milestone as it is invalid?
Comment From: sbrannen
I guess this should be removed from the
5.2.4milestone as it is invalid?
Indeed. Done. Thanks.