Remove redundant character escape in RegExp
Comment From: sbrannen
Whether or not it makes sense to remove those unnecessary escape sequences is (in my opinion) a matter of taste. In other words, it's technically correct to omit the escaping for a closing brace (and more concise), but many people are accustomed to escaping all special characters (opening and closing).
In any case, was there a reason you did not remove all such unnecessary escaping in the GLOB_PATTERN?
Comment From: hyeonisism
@sbrannen When I revised the code, there was an unnecessary RegExp and I deleted it.
But listening to your opinion, I seem to have tried to break down the style that many have.
However, I think there is progress if technological pursuit is correct. What is your opinion?
Apart from the earlier story, GLOB_PATTERN part is a mistake I missed.
Thank you for sharing good idea.
Comment From: rstoyanchev
We discussed this within the team and decided to go ahead with this change in part to make the expressions more readable, and in part to avoid IDE warnings that add to the noise. To make matters worse, IntelliJ flags this warning while Eclipse doesn't. This means that while @SuppressWarnings would work in IntelliJ, in Eclipse it would be flagged as unnecessary. All of these outcomes only add more noise.
So we are okay with the change, but it needs to be applied consistently eveywhere. These are other classes where this exists:
AbstractHttpSendingTransportHandler
ClassPathResourceTests
CustomizableTraceInterceptor
MessageBrokerBeanDefinitionParserTests
RedirectView
RegexPathElement
TestContextResourceUtils
UriComponents
UriComponentsBuilder
WebSocketMessageBrokerConfigurationSupportTests
Let me know if you are you going to make those changes.
Comment From: hyeonisism
@rstoyanchev You mean If I wanted to, I have to apply this whole thing? I'd like to. Can I proceed from this Branch?
Comment From: rstoyanchev
Yes if you'd like to, please go ahead and make those updates in this branch. I'll update the PR title accordingly to reflect the expanded scope.
Comment From: rstoyanchev
Thanks, I think the commits can be squashed. Logically it's one change applied everywhere.