To prevent confusion about the build(boolean) method
Comment From: rstoyanchev
@eitan613 I'm fine to make some Javadoc improvements but I'm not sure if the proposed change makes much of a difference. Either way the encoded flag states what it means. The fact that this will be validated/asserted doesn't aid in understanding.
I was thinking rather that the UriComponentsBuilder.fromUri(URI) method should state that you must then use .build(true) and reversely on .build(true) point out that if the builder was created from a URI the flag should be true.
Or otherwise please clarify what confused you so we can find a way to improve.
Comment From: eitan613
@rstoyanchev truth be told I wasn't really using this code and after looking at it a bit I wasn't really confused about it. I noticed that others were, the user who opened up issue #25444 for example, and when I looked around online it seems others were confused also. It sounds to me like the change about the UriComponentsBuilder.fromUri(URI) would help but it also seemed to me that people thought that the build(true) method was encoding the URI. In which case it might be helpful to clarify that it is not encoding and the boolean passed in is to verify if it was already encoded
Comment From: rstoyanchev
Okay I see. I think it already says that but we can certainly strengthen the language used. It does sound more like the confusion might be from looking at the method and assuming what it means.
Comment From: eitan613
Anything else I can/should do then?