Comment From: wilkinsona
This causes some test failures in LdapAutoConfigurationTests due to this change that was made to fix https://github.com/spring-projects/spring-ldap/issues/473.
It looks like anonymousReadOnly on LdapProperties needs to become a Boolean as the default changes depending on whether or not there's a username (which is mapped to userDn).
Comment From: snicoll
There is that and there is the fact that userDn is initialized to an empty String by default (which means our defaults do not match that).
This change means essentially that the flag is now true by default without any extra configuration. I am not sure we should upgrade with the current arrangement.
Comment From: snicoll
This change means essentially that the flag is now true by default without any extra configuration.
I was wrong there since the code does a isEmtpy check so that empty string is treated the same as null. I've added a test to exercise the scenario where a username is set.