Ready to be reviewed before merging in master
since I would like to begin having feedback with real applications using Spring Framework snapshots.
Notice that this PR is implemented with buffer copy instead of optimized buffer wrapping because the latter hangs since Callback#succeeded
doesn't allow releasing the buffer and requesting more data at different times (required for Mono<DataBuffer>
for example).
Simone is aware of that issue and will see if it can be changed on Jetty side (not sure yet). That could be changed with an additional commit if that becomes possible in the future.
Issue: SPR-15092
Comment From: sdeleuze
I have taken in account your feedback @poutsma thanks.
Comment From: rstoyanchev
Sorry for the delayed response, but my comments above. Let's get this ready for master, and continue there as needed.
Comment From: sdeleuze
@rstoyanchev Thanks for your feedback, I think I have taken your remarks in account. I have not yet merged it in master
because I have a strange remaining issue: SseIntegrationTests
and WebClientIntegrationTests
fail on command line with ./gradlew clean test
(AssertionError
, likely timeouts) but succeed in IntelliJ IDEA. Any idea?
Comment From: sdeleuze
Merged via https://github.com/spring-projects/spring-framework/commit/a87764f1fd218356690e05cf2aa964e92202eed6.