Backport of gh-26838
Comment From: spring-projects-issues
Fixed via 3ab270e0f13e5dc41d6b9600fb8507c3d48f733c
Comment From: ShindongLee
@sdeleuze @jhoeller @spring-projects My PR was merged to 5.3.7 and 5.2.15 but my name is missing on contributors in 5.3.7 release note 😭 Please check 😭
Comment From: sbrannen
@sdeleuze @jhoeller @spring-projects My PR was merged to 5.3.7 and 5.2.15 but my name is missing on contributors in 5.3.7 release note 😭
I think that's because @sdeleuze included your work in his own commit (instead of merging your PR) and listed you as a co-author in the commit message as follows.
Co-authored-by: hojongs <hojong.jjh@gmail.com>
Co-authored-by: bjh970913 <bjh970913@gmail.com>
Are you one of those listed co-authors? If so, which one?
Comment From: sbrannen
Please check 😭
I have manually added you as a contributor to the 5.3.7 release notes.
Comment From: ShindongLee
Co-authored-by: hojongs hojong.jjh@gmail.com Co-authored-by: bjh970913 bjh970913@gmail.com ```
Are you one of those listed co-authors? If so, which one? Thanks ! @sbrannen I'm the one who made a PR, and @hojongs & @bjh970913 are my teammates who helped me a lot for debugging and writing the test codes. Acutually I put them as co-authors. If you don't mind can you list them too? Thank you very much.
Comment From: sbrannen
Thanks !
You're welcome.
I'm the one who made a PR,
OK. I now see that you're listed as the author of commit 07ba95739bf4451742e4ee6b4d4b2d0ee5f701bf.
So perhaps the script that generates our release notes did not automatically include you as a contributor since that commit referenced the original issue instead of your PR. But I am merely speculating.
@snicoll, can you perhaps explain why that happened?
and hojongs & bjh970913 are my teammates who helped me a lot for debugging and writing the test codes. Acutually I put them as co-authors. If you don't mind can you list them too? Thank you very much.
Sure. I'll add them to the release notes, too.
Can you please confirm that their GitHub handles are @hojongs and @bjh970913?
Comment From: ShindongLee
@sbrannen
Yes their ids are right.
Thank you for maintaining great framework. Our back-end team develops every server with Spring. We will try to contribute again if we have another chance. Thanks!
Comment From: snicoll
@snicoll, can you perhaps explain why that happened?
The tool does not parse commit messages at all.