Comment From: pivotal-cla
@78356052 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@78356052 Thank you for signing the Contributor License Agreement!
Comment From: snicoll
@78356052 thanks for the PR. Unfortunately it's not easy to get the point of the PR with a generic title, no description and no additional tests. Can you please explain why you think this change is worthwhile?
Comment From: 78356052
@78356052 thanks for the PR. Unfortunately it's not easy to get the point of the PR with a generic title, no description and no additional tests. Can you please explain why you think this change is worthwhile?
No need to recycle again
Comment From: sbrannen
No need to recycle again
@78356052, did you read the warning at the top of the method you modified?
// WARNING: Although it may appear that the body of this method can be easily
// refactored to avoid the use of multiple loops and multiple lists, the use
// of multiple lists and multiple passes over the names of processors is
// intentional. We must ensure that we honor the contracts for PriorityOrdered
// and Ordered processors. Specifically, we must NOT cause processors to be
// instantiated (via getBean() invocations) or registered in the ApplicationContext
// in the wrong order.
//
// Before submitting a pull request (PR) to change this method, please review the
// list of all declined PRs involving changes to PostProcessorRegistrationDelegate
// to ensure that your proposal does not result in a breaking change:
// https://github.com/spring-projects/spring-framework/issues?q=PostProcessorRegistrationDelegate+is%3Aclosed+label%3A%22status%3A+declined%22
Have you compared your proposal with similar proposals that were rejected?
https://github.com/spring-projects/spring-framework/issues?q=PostProcessorRegistrationDelegate+is%3Aclosed+label%3A%22status%3A+declined%22
Comment From: sbrannen
Closing as an exact duplicate of #26273, which got declined for the reasons given in https://github.com/spring-projects/spring-framework/pull/26273#issuecomment-750867140.