First stab at a fix this issue. For discussion see http://jira.springsource.org/browse/SPR-8941.
Comment From: cbeams
Hi Hannes,
Per my comments on SPR-8941, this is looking pretty good with regard to content. Please read through and follow the contributor guidelines (which didn't exist when you first submitted this pull request), and we'll go from there.
A couple things that aren't expressly in the guidelines:
- whitespace in method invocations/declarations (getPhase(bean), not getPhase( bean ), etc)
- braces on same line, not newline, etc
- don't use final on local variables unless necessary (nothing wrong with this, it just hasn't been the convention in the rest of the framework)
Thanks!
Comment From: pivotal-issuemaster
@eyealike Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: rstoyanchev
Closing as the related issue is closed too.
Comment From: pivotal-cla
@eyealike Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.