- copy "org.springframework.data.transaction" package from spring-data-commons as "org.springframework.transaction.chained" into spring-tx module
- change logger from slf4j to commons-logging
Comment From: pivotal-issuemaster
@akiraly Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-issuemaster
@akiraly Thank you for signing the Contributor License Agreement!
Comment From: janetgregory
I want to opt out of this.. im not good at this thank you
On Feb 13, 2017 4:51 PM, "Pivotal Issuemaster" notifications@github.com wrote:
@akiraly https://github.com/akiraly Thank you for signing the Contributor License Agreement https://cla.pivotal.io/sign/spring?repositoryId=spring-projects/spring-framework&pullRequestId=1324 !
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-framework/pull/1324#issuecomment-279533922, or mute the thread https://github.com/notifications/unsubscribe-auth/AYYhbcRWyrPqjquv1tyInXgHjZjl6ZOcks5rcNBLgaJpZM4L_w8f .
Comment From: lqjack
@akiraly why do you change logger from slf4j to commons-logging?
Comment From: akiraly
@lqjack Because afaik spring-framework (and spring-tx) uses the commons-logging API and not the slf4j API for logging.
Comment From: snicoll
@akiraly thanks for the PR but the related issue has been declined (see https://github.com/spring-projects/spring-framework/issues/18308#issuecomment-977918238) so I am going to close this PR as well.