modify the implement of submit method
Comment From: pivotal-issuemaster
@qudh1 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-issuemaster
@qudh1 Thank you for signing the Contributor License Agreement!
Comment From: snicoll
@qudh1 we need a Jira issue to discuss this change. Can you please create one?
Comment From: qudh1
Sure, @snicoll, the jira issue is https://jira.spring.io/browse/SPR-17219. Thank you.
Comment From: waasikhaan
How can you take advantage of CompletionService's take method? Don't you think ExecutorService is enough here?
Comment From: qudh1
@waasikhaan， thanks for your comment. Could you share why ExecutorService is enough here?
Comment From: waasikhaan
@qudh1
A CompletionService that uses a supplied Executor to execute tasks. This class arranges that submitted tasks are, upon completion, placed on a queue accessible using take.
This is what the documentation said so IMO if you are not exposing the ComplitionService then you will not be able to take advantage of ComplitionService. Correct me if i am wrong here. :)
Comment From: snicoll
Sorry it took us so long to process this. I agree with @waasikhaan and the method you've changed is really meant to invoke the same API on the underlying ExecutorService. Thanks for the PR, in any case.