I've noticed, that there is a piece of sample code that does not compile with Spring 5.x, because the the EntityManager interface does not implement AutoCloseable until JPA 3.x (relevant commit in jpa-api)

The sample should be fine for Spring 6.x - so I'm not sure if targeting main is the correct workflow here?

  • Partially reverts 189e1afc6ee6bd40b
  • Releates to https://github.com/spring-projects/spring-framework/issues/22269

Thanks for looking at this!

Comment From: sbrannen

Good catch!

And congratulations on submitting your first PR for the Spring Framework.

The sample should be fine for Spring 6.x

We're actually still using JPA 3.0 (not yet on 3.1) on main. So the example should also be changed for 6.0 for the time being.

so I'm not sure if targeting main is the correct workflow here?

I'll apply your changes to 5.3.x and forward merge to main.

Comment From: sbrannen

This has been merged into 5.3.x and main.

Thanks