Using various new features from Java 9-17 such as String.repeat()
and pattern matching instanceof.
Comment From: sbrannen
@AbstractCoderX, have you run a full local build?
./gradlew check
Just curious, because the last time I checked.... we could not use switch expressions due to a limitation with Checkstyle (specifically Spring Java Format).
Comment From: slutmaker
Just curious, because the last time I checked.... we could not use switch expressions due to a limitation with Checkstyle (specifically Spring Java Format).
As far as I can see, this has already been fixed, why does the codestyle check fail?
Comment From: sbrannen
Just curious, because the last time I checked.... we could not use switch expressions due to a limitation with Checkstyle (specifically Spring Java Format).
As far as I can see, this has already been fixed, why does the codestyle check fail?
The fix is in spring-javaformat
0.0.30 which has not been released. We are therefore still using spring-javaformat
0.0.29.
https://github.com/spring-projects/spring-framework/blob/b24cbc5e9791c87e033d1779b4a1a88f90b1e372/build.gradle#L323
Comment From: sbrannen
The fix is in
spring-javaformat
0.0.30 which has not been released. We are therefore still usingspring-javaformat
0.0.29.https://github.com/spring-projects/spring-framework/blob/b24cbc5e9791c87e033d1779b4a1a88f90b1e372/build.gradle#L323
In light of that, @AbstractCoderX feel free to move the "switch expression" changes to a separate PR so that we can merge in the other changes independent of that.
Comment From: slutmaker
The fix is in
spring-javaformat
0.0.30 which has not been released. We are therefore still usingspring-javaformat
0.0.29. https://github.com/spring-projects/spring-framework/blob/b24cbc5e9791c87e033d1779b4a1a88f90b1e372/build.gradle#L323In light of that, @AbstractCoderX feel free to move the "switch expression" changes to a separate PR so that we can merge in the other changes independent of that.
done
Comment From: sbrannen
@AbstractCoderX, are you planning on submitting a PR with the "switch expression" changes?
Comment From: slutmaker
@AbstractCoderX, are you planning on submitting a PR with the "switch expression" changes?
I will do it this week
Comment From: slutmaker
@sbrannen https://github.com/spring-projects/spring-framework/pull/28014