The determineTimeout(TransactionDefinition definition)
method will fall back to this manager's default timeout if the transaction definition doesn't specify a non-default value , so can remove the code here and use determineTimeout(TransactionDefinition definition)
directly
Comment From: pivotal-issuemaster
@jujunchen Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-issuemaster
@jujunchen Thank you for signing the Contributor License Agreement!
Comment From: jhoeller
ConnectionHolder.setTimeoutInSeconds
is not designed to deal with special constants such as TransactionDefinition.TIMEOUT_DEFAULT
; it rather expects no call at all for a default scenario. The condition in our existing code takes that into account.