Comment From: bclozel
@sbrannen Could you elaborate on why this is in the triage queue? Is there something to be discussed or clarified? Is there a reason we don't merge this right now?
Comment From: venkateshvictory
Sorry I am learning I did it only
On Tue, 21 Jun 2022, 1:47 pm Brian Clozel, @.***> wrote:
@sbrannen https://github.com/sbrannen Could you elaborate on why this is in the triage queue? Is there something to be discussed or clarified? Is there a reason we don't merge this right now?
— Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-framework/pull/28646#issuecomment-1161417793, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP5LHYBGKOESDHV4DOYSHBLVQF3DFANCNFSM5ZBYIEFQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Comment From: venkateshvictory
Can you tell me about entitymanager and about dao
On Tue, 21 Jun 2022, 2:18 pm venkatesh doddi, @.***> wrote:
Sorry I am learning I did it only
On Tue, 21 Jun 2022, 1:47 pm Brian Clozel, @.***> wrote:
@sbrannen https://github.com/sbrannen Could you elaborate on why this is in the triage queue? Is there something to be discussed or clarified? Is there a reason we don't merge this right now?
— Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-framework/pull/28646#issuecomment-1161417793, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP5LHYBGKOESDHV4DOYSHBLVQF3DFANCNFSM5ZBYIEFQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Comment From: rstoyanchev
I think this could be merged indeed. There might also be a further opportunity to improve ExtendedWebExchangeDataBinder
which overrides and repeats the base class implementation of getValuesToBind
. I'll have a closer look.
Comment From: sbrannen
@sbrannen Could you elaborate on why this is in the triage queue? Is there something to be discussed or clarified? Is there a reason we don't merge this right now?
I put it in the triage queue because I believed that it probably could be merged as soon as someone got a chance to review the PR in detail. When I noticed the PR I didn't have time to review it in detail, so I thought the triage queue was the easiest way to signal to the team that this is likely some low hanging fruit.