This commit removes deprecation from PathMatchConfigurer::isUseTrailingSlashMatch
that was accidentally introduced in 5225a574.
Comment From: rstoyanchev
Not accidental actually. Generally, configurer classes related to WebMvcConfigurer
only need to expose setters as public API, while getters are mainly for use from WebMvcConfigurationSupport
and don't need to be used from application code. This is why they tend to be hidden, except in some cases where the need arises to be able to check.
So those getters in PathMatchConfigurer became public by accident originally, and were later deprecated with the intent to hide them eventually for consistency.
Can you expand a bit more on what you're trying to do?
Comment From: vpavic
Hmm, my observation that PathMatchConfigurer::isUseTrailingSlashMatch
deprecation was accidental is based on its usage in WebMvcConfigurationSupport
and the fact that there's no apparent replacement.
So you're saying it was deprecated with the intent to reduce the visibility to package private (and not replacing the method with something else)? In that case my PR is indeed invalid. But if you're reducing the visibility I think you still likely need to drop to deprecation.
Comment From: rstoyanchev
Yes that was the intent, to stop exposing them as a public API. Once they are protected, the deprecations can be be dropped and they would continue to be used internally.
Comment From: bclozel
Closing as this change was intended.