Reference Issue: Issue-29008
I expect to need test code, but I can't find the previously written test code. Can you give me a guide on writing test code?
Comment From: pivotal-cla
@meloning Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@meloning Thank you for signing the Contributor License Agreement!
Comment From: sdeleuze
The proposed change on RestTemplate
would be consistent with what we do in WebMvcConfigurationSupport
here and WebClient
which do that because Kotlin serialization require an explicit signal (the class should be annotated with @Serializable
) otherwise serialization is delegated to Jackson.
@rstoyanchev Are you ok with doing that on 5.3.x
even if we are late in the patch release cycle? It will be a slight change of behavior but should impact very few people and I think it could be considered as a bug and a lack of consistency.
Comment From: meloning
Also, parts AbstractMessageBrokerConfiguration and AllEncompassingFormHttpMessageConverter are in the same situation, can I fix it in the PR and upload it?
Comment From: meloning
Hello @sdeleuze @rstoyanchev
I added kotlinSerialization test case in RestTemplateTests
and fixed the case where MessageBrokerConfigurationTests
that test AbstractMessageBrokerConfiguration
fails.
Please check and review. Thank you
Comment From: meloning
Hi @rstoyanchev @sdeleuze There is no answer yet, so I'm leaving a comment again. Please let me know if there are any errors or if there are any additional considerations.
Please check. Thank you
Comment From: sdeleuze
Merged a refined version via bb3ada4a673c689b9d5c854ec021b8e96e32c447, thanks!