Since the RuntimeHintsAgentCondition
is based solely on the result of invoking a boolean
static method, there is no need to implement a custom ExecutionCondition
. For such use cases, the @EnabledIf
support in JUnit Jupiter is sufficient.
This commit therefore replaces the custom RuntimeHintsAgentCondition
with use of @EnabledIf
as a meta-annotation.
Please note that this PR also removes the @Tag("RuntimeHintsTests")
declaration. If that is still needed for particular use cases, that can be retained.
Comment From: sbrannen
@bclozel, since you just recently introduced RuntimeHintsAgentCondition
, I wanted to run this by you (in the form of a PR) before pushing to main
.
Comment From: sbrannen
By the way, if you're concerned about reduced diagnostics as a result of this change, I just pushed https://github.com/junit-team/junit5/commit/73d868ce0f09ddb225882062afb174a263dfa7c7 to address that.
Comment From: bclozel
Thanks @sbrannen , I've merged this PR and just reinstated the tagging information. It's still early so we'll collect more feedback from the Spring team and see if more flexibility is requested.
Comment From: crazycodeon
这是来自QQ邮箱的假期自动回复邮件。 您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。
Comment From: bclozel
Enjoy your holiday @crazycodeon 👋