Change liveness-port to management-port in liveness and readiness probe example. #21648
Comment From: wilkinsona
Thanks for the PR, @fastso. There are some commits included in it that shouldn't be there. I think that may be because you have used 2.3.x as the base branch for a change that you made on top of the master branch. Can you please try changing the base branch of your PR from 2.3.x to master?
Comment From: fastso
@wilkinsona Thank you for your help, I changed the branch from 2.3.x to master.
Comment From: mbhave
Thanks for the PR @fastso. Since management-port can mean a few things things we should probably add a note below that example clarifying what it means. Essentially, it means the port that the actuator endpoints are available on. It could be the server port if a separate management port has not been configured or the management.server.port property if that has been explicitly configured. Would you be able to update the PR with the NOTE that clarifies this?
Comment From: fastso
Thanks for the advice @mbhave . I added the note for management-port, plz confirm.
Comment From: philwebb
Thanks very much for the PR @fastso. I've merged this into 2.3.x along with a minor edit to the naming. I decided to use the term <actuator-port> rather than management-port.