Constructors of abstract classes can only be called in constructors of their subclasses. So there is no point in making them public.
Comment From: sbrannen
Hi @lauvsong,
Thanks for submitting your first pull request for the Spring Framework! 👍
Regarding the proposed changes, we actually have numerous places across the code base where methods or constructors are declared as public
in abstract
or non-public types.
Thus, although the rationale for the proposed changes is technically correct, we would prefer not to accept PRs that make such small changes, in order to discourage the community from submitting similar PRs for which we unfortunately do not have the resources to process.
If you would like to make contributions to the Spring Framework, consider looking for issues with documentation or see if there are any issues that have been assigned the ideal-for-contribution label.
Comment From: lauvsong
I can relate to. Thank you for the detail feedback 👍