server.error.include-binding-errors had no effect on BasicErrorController.isIncludeBindingErrors(), due to wrong property being used

Comment From: pivotal-issuemaster

@Aurdo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Comment From: pivotal-issuemaster

@Aurdo Thank you for signing the Contributor License Agreement!

Comment From: scottfrederick

Good catch @Aurdo, thanks. This was my copy-and-paste mistake that happened when the control of the message and errors fields were split from one property into two.

The reason this wasn't caught earlier is that the tests to verify the behavior of BasicErrorController always test the server.error.include-message and server.error.include-binding-errors fields together. Those tests should be split up so that include-message and include-binding-errors are tested separately.

If you'd like, you can also modify BasicErrorControllerIntegrationTests to split up those tests and add that change in another commit to this PR. If you'd prefer not to do that, I can modify the tests when the PR is merged.

Comment From: Aurdo

Good catch @Aurdo, thanks. This was my copy-and-paste mistake that happened when the control of the message and errors fields were split from one property into two.

The reason this wasn't caught earlier is that the tests to verify the behavior of BasicErrorController always test the server.error.include-message and server.error.include-binding-errors fields together. Those tests should be split up so that include-message and include-binding-errors are tested separately.

If you'd like, you can also modify BasicErrorControllerIntegrationTests to split up those tests and add that change in another commit to this PR. If you'd prefer not to do that, I can modify the tests when the PR is merged.

@scottfrederick whatever works for you is fine with me. Just not sure how long would it take to clone and import project locally

Comment From: scottfrederick

@Aurdo If you haven't cloned, imported, and built the project already don't worry about it. I'll fix up the tests.