Yanming Zhou opened SPR-13310 and commented
sometime we need copy a shadow package for export remote service interface, service interface depend domain object which include domain enum type, it is necessary to support conversion between origin Enum type to shadow Enum.
Reference URL: https://github.com/spring-projects/spring-framework/pull/852
Comment From: spring-projects-issues
Stéphane Nicoll commented
Hey, thanks for the pull request. I am not keen on adding that converter by default. I was also wondering why you were silently ignoring a missing value in the shadow annotation. Is that on purpose? I think we should generate an exception in such a case.
Comment From: spring-projects-issues
Stéphane Nicoll commented
Can you please get back to me? I don't deny this to be useful but I am willing to push a version that throws an exception if a value is missing in the shadow annotation. It wouldn't be very useful if we pushed that and you don't have any use for it. Any feedback on the silent catch will be helpful.
Comment From: spring-projects-issues
Yanming Zhou commented
I have updated the commit, please review it, It's my first PR, I'm excited if it will be merged to spring.
Comment From: spring-projects-issues
Stéphane Nicoll commented
Sorry, I can't see any update for this. Can you just reply to my questions which will help merging that PR.
Comment From: spring-projects-issues
Yanming Zhou commented
I have updated this commit to avoid swallow IllegalArgumentException.
Comment From: jhoeller
Superseded by #852.