imho improved tests for gh-25140, as solicited by @jhoeller
As promised in gh-25159, I am submitting a second suggestion for Testing the exiting code of
CollectionUtils.toMultiValueMap
The suggestion was to create for this MultiValueMap same tests as for
LinkedMultiValueMap
present in
LinkedMultiValueMapTests
This, however, produced a very high code duplication, which I did not find very elegant.
I think the better way is to use Jupiter properly, to instantiate various types of MultiValueMap and test the contract for each of them.
Like this test code is not duplicated and the contracts are consistent with each other.
This is just a suggestion.
I am open for suggestions in case this does not fit your expectations.
Kind regards
Comment From: midumitrescu
@sbrannen thank you very much for your review.
I will also change the name of the test to:
MultiValueMapAdaptersTests to reflect current changes done by Juergen.
Comment From: midumitrescu
@sbrannen done
I did not trust myself to delete
org.springframework.util.LinkedMultiValueMapTests
But imho they are now fully migrated with the parameterized tests
Comment From: snicoll
Thanks @midumitrescu, I've enabled the tests that were disabled as the fix has been added in the meantime.