resolve @async circular dependencies problem
Comment From: snicoll
@yuanyu1997 thanks for the PR but we now have 5 PRs for the same request, please hold off creating new ones as it generates unnecessary noise to the 3K+ watchers of this repository.
Comment From: baker-yuan
@yuanyu1997 thanks for the PR but we now have 5 PRs for the same request, please hold off creating new ones as it generates unnecessary noise to the 3K+ watchers of this repository.
sorry, I've closed four.
Comment From: baker-yuan
@yuanyu1997 thanks for the PR but we now have 5 PRs for the same request, please hold off creating new ones as it generates unnecessary noise to the 3K+ watchers of this repository.
Will this code merge?
Comment From: snicoll
It is very unlikely in its current form since it does not have any test that exercises the code you've changed. Please update the PR with more tests that break before your change and don't after. If there is a reference to an existing issue for this, please add it as well. Thank you.
Comment From: funky-eyes
@yuanyu1997 thanks for the PR but we now have 5 PRs for the same request, please hold off creating new ones as it generates unnecessary noise to the 3K+ watchers of this repository.
Will this code merge?
I personally think that there are currently five duplicate prs, you can participate in pr review instead of resubmitting
Comment From: baker-yuan
It is very unlikely in its current form since it does not have any test that exercises the code you've changed. Please update the PR with more tests that break before your change and don't after. If there is a reference to an existing issue for this, please add it as well. Thank you.
I added test cases
Comment From: snicoll
@baker-yuan thanks for adding the test. I am not keen to bring this extra complexity for supporting cyclic dependencies. There are ways to break that using Optional or ObjectProvider and this should be the preferred option anyway.
Comment From: pivotal-cla
@baker-yuan Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.