This is a fix for https://github.com/spring-projects/spring-framework/issues/22146
Comment From: sbrannen
For future reference, there was no need to close #25047.
If you need to make changes to a PR, you can push additional commits to the PR branch and rebase on the latest master
if necessary.
Comment From: sbrannen
@aclement, do you have time to review the proposal?
Comment From: aclement
It looks reasonable to me @sbrannen . The only concern I'd have is that we do allowable SpEL compilation of inline lists (not inline maps yet):
In InlineList:
public boolean isCompilable() {
return isConstant();
}
So maybe a few tests verifying compiled expressions using inline lists are still OK with the constant computation extended to include OpMinus nodes. I think it'll be ok from browsing the code, but worth testing.
Comment From: SammyVimes
@aclement I just added tests verifying compilation, looks like it's still OK
Comment From: SammyVimes
Hello! I wonder if we can proceed with the review and merge this? :)
Comment From: sdeleuze
Rebased and merged, thanks for your contribution and sorry for the delay.
Comment From: sbrannen
Indeed, thanks for the PR, @SammyVimes! 👍
I unfortunately forgot about this PR and so only got around to reviewing it after it had been merged.
You can see the result of my belated review in e7cf54d4e236ac1e5e5dd59899aae268bcace21d.