Sergii Karpenko opened SPR-16451 and commented

Segregate basic trace logic from logic responsible for log message construction. Move out invokeUnderTrace to BasicTraceInterceptor and parametrise it with entranceConsumer, exitConsumer, exceptionConsumer.

Except of violating single responsibility principle current implementation doesn't allow me to distinguish entrance message from exit massages.

This should fix both points and also will allow to avoid of expensive replacePlaceholders calls if necessary.


No further details from SPR-16451

Comment From: spring-projects-issues

Sergii Karpenko commented

BTW, BasicTraceInterceptor also can be used as superclass for SimpleTraceInterceptor to avoid code duplication

Comment From: spring-projects-issues

Sergii Karpenko commented

If you don't mind I'd like to introduce this safe refactoring.

Comment From: snicoll

There is no longer a BasicTraceInterceptor so I can't know for sure what, if anything, is still applicable at this time. Sorry this got overlooked.