Phil Webb opened SPR-15514 and commented

Spring Boot would like to track when property sources are changed on a MutablePropertySources instance. One way to do this would be to add listener support.


No further details from SPR-15514

Comment From: spring-projects-issues

Phil Webb commented

https://github.com/philwebb/spring-framework/tree/SPR-15514

Comment From: spring-projects-issues

Phil Webb commented

Juergen Hoeller I wasn't able to make the changes to Spring Boot to be 100% sure that this will help us. Nevertheless, I think it's a worthwhile change still and good to go if you're happy to merge it.

Comment From: spring-projects-issues

Juergen Hoeller commented

Phil Webb, where are we with this use case in Boot? Is the change desperately needed, or can we get away without it, comparing MutablePropertySources state some other way?

Comment From: spring-projects-issues

Phil Webb commented

Juergen Hoeller It would be used here. We currently simulate it by comparing state as you suggest, but this isn't great for performance.

Comment From: spring-projects-issues

Juergen Hoeller commented

I'm afraid I'll have to move this to the backlog again. With plenty of other issues up in the air for 5.0.2, I don't see myself getting to this. And since it is effectively 'just' a performance optimization but requires the introduction of new API, I don't want to rush it in either.

Comment From: snicoll

@philwebb I am wondering if Spring Boot still needs this. I've had a look on main and I couldn't find back the code you've referenced.

Comment From: philwebb

@snicoll I think this can be closed now, the caching approach we take has moved on a lot. We can always reopen the issue if do another round of performance work in that area.