Hi!
Proposed changes introduce additional metadata property "sourceCanonicalType" holding the canonical name of the source type. Existing property "sourceType" remains unchanged for backward compatibility.
Fixes #10886.
Regards, Boris
Comment From: borisfox73
Keeping canonical source type name in the stored metadata is needed to determine whether a previous metadata item has been deleted in the current [incremental] build to exclude it from merging with the new metadata. The Elements API used in the MetadataCollector#deletedInCurrentBuild for this check does not provide a method to lookup type elements by their class names. Elements#getTypeElement accepts canonical name (one with components separated by dots), not a class name (separated by $ sign). I couldn't (yet) find a way to get a type element from processing environment by it's class name.
Test scenario for nested configuration properties has been implemented.
Comment From: borisfox73
Fallen too behind, and introduces a breaking change anyway.
Comment From: snicoll
Sorry about that @borisfox73. I couldn't manage to figure out how to fix this one and, priority-wise, we've been quite busy on other topics. If that resume, I'll ping on the related issue. Thanks for your contribution, in any case
Comment From: borisfox73
Don't worry, it's ok :) I have another fix we're successfully using awhile now, with simple flat to canonical class name conversion replacing dollar signs with dots. It passess the test scenario and seems to work flawlessly on our projects, but obviously won't work for properties class names containing dollar signs themselves (e.g. "MyTestProperties$"). I can share it as a new pull request.
Regards, Boris
09.07.2020 18:52, Stéphane Nicoll пишет:
Sorry about that @borisfox73 https://github.com/borisfox73. I couldn't manage to figure out how to fix this one and, priority-wise, we've been quite busy on other topics. If that resume, I'll ping on the related issue. Thanks for your contribution, in any case
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-boot/pull/20720#issuecomment-656000357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHL33OSAGTAQSTXP3ZSHFRTR2WALTANCNFSM4LWGE2AA.