Spring Remove unnecessary else statements in RequestMethodsRequestCondition

The main change is the simplification of the conditional structure by removing unnecessary else statements.

Changes Made: - Removed redundant validations - Removed unnecessary else statements - Retained the original logic and functionality.

• [x] The test code was executed and passed successfully.

Comment From: snicoll

I don't think the else here is unnecessary. It is now because there's a return but the algorithm may change in the future so the code as it is is more robust IMO. Thanks for the PR, in any case.

Comment From: Ryan-Dia

@snicoll

It is now because there's a return but the algorithm may change in the future so the code as it is is more robust IMO.

I agree with this perspective. However, I'm curious about your thoughts on modifying the nested logic within the if statement.

📌 Reference

before

if (isEmpty() && other.isEmpty()) {
      return this;
  }
  else if (other.isEmpty()) {
      return this;
  }
  else if (isEmpty()) {
      return other;
  }

after

if (other.isEmpty()) {
      return this;
  }
  else if (isEmpty()) {
      return other;
  }