Description:
The current AnnotationVisitor class in ASM lacks comprehensive documentation and could benefit from improved error handling and logging. This proposed enhancement aims to address these aspects to make the class more user-friendly and robust.
Proposed Changes:
- Add Javadoc comments to explain the purpose and usage of each method in the AnnotationVisitor class.
- Validate API versions to ensure only supported versions are accepted.
- Introduce centralized exception handling for annotation visits, including logging to the standard error stream.
- Enclose method calls to the underlying AnnotationVisitor in try-catch blocks to handle exceptions gracefully.
Expected Benefits: - Improved code readability and usability for developers using the ASM library. - Better error reporting and debugging capabilities during annotation visits.
Additional Information: - This enhancement aligns with best practices for library usage and aims to enhance the overall user experience.
Comment From: sbrannen
Thanks for the proposal.
However, please note that classes under the org.springframework.asm package are a repackaged fork of the third-party library ASM. Any refactoring to those classes should take place upstream in the originating repository. The Spring Framework will then pick up the changes when syncing with official updates of the forked third-party libraries.
In light of that, I am closing this issue.