Replaced the use of String.join combined with Collections.nCopies to generate SQL placeholders with the more concise and efficient String.repeat method.
- This change simplifies the code and improves readability.
- Performance might be slightly improved as String.repeat is more direct.
No functionality change; only a refactoring to improve code clarity and efficiency.
Benchmark Mode Cnt Score Error Units JoinTest.nCopies thrpt 5 5938.720 ± 84.293 ops/ms JoinTest.repeat thrpt 5 37268.560 ± 1977.043 ops/ms
Comment From: pivotal-cla
@luckygc Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@luckygc Thank you for signing the Contributor License Agreement!
Comment From: sbrannen
@luckygc, please note that there is no need to close a PR and open a new one (##33365) identical to the previous one (this PR).
Instead, you can push additional commits to the existing PR.
Comment From: luckygc
@sbrannen Thank you for the guidance. I understand now and will make sure to push additional commits to the existing PR next time instead of creating a new one.