This brings the HttpComponentsClientHttpRequestFactory into alignment with JDK, Jetty, OkHttp3 and SimpleClient ClientHttpRequestFactory's.
The read timeout is a pretty common value to set, so I think it is helpful to allow configuring it directly from the factory, vs. supplying a custom RequestConfig
and HttpClient
to the factory.
Comment From: pivotal-cla
@cmagnuson Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@cmagnuson Thank you for signing the Contributor License Agreement!
Comment From: simonbasle
thanks for the contribution @cmagnuson. Looks good to me, I will polish the javadoc/formatting and add some tests before merging, fixing the checkstyle error along the way