https://github.com/spring-projects/spring-framework/blob/ac5c8adb9830939e2329f1e16727c522a172c7c8/framework-docs/modules/ROOT/pages/web/webmvc/mvc-controller/ann-requestmapping.adoc?plain=1#L122
This line in the docs is not rendered correctly. In this case passthrough should be marked with double plus signs, because the plus sign of the regex is interpreted as the end of the inline passthrough.
++"/projects/{project:[a-z]+}/versions"++
double plus ist documented on https://docs.asciidoctor.org/asciidoc/latest/pass/pass-macro/
Comment From: bclozel
I'm turning this issue into an ideal-for-contribution
issue. This means it is well suited for first time contributors and we can help you ship your first Spring or open source contribution. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software.
If you have had a pull request merged before, consider leaving this one for someone new. Thanks!
Problem
@bohni pointed out that our reference documentation in this section does not render the mapping pattern as it should. Instead of reading "/projects/{project:[a-z]+}/versions"
we are seeing "/projects/{project:[a-z]}/versions"+
Solution
As pointed out in the same comment, changing this line: https://github.com/spring-projects/spring-framework/blob/ac5c8adb9830939e2329f1e16727c522a172c7c8/framework-docs/modules/ROOT/pages/web/webmvc/mvc-controller/ann-requestmapping.adoc?plain=1#L122
to ++"/projects/{project:[a-z]+}/versions"++
should fix the rendering problem.
You can change this line locally and then check that the documentation renders properly by:
- running
./gradlew antora
- then opening the
framework-docs/build/site/6.1-SNAPSHOT/web/webmvc/mvc-controller/ann-requestmapping.html
file in your browser
Steps to Fix
- [ ] Claim this issue with a comment below and ask any clarifying questions you need
- [ ] Set up a repository locally following the contributing and building from source docs. NOTE: you should check out the
6.1.x
and submit the PR against it, we will merge the change forward in 6.2 when applying your contribution. - [ ] Try to fix the issue following the steps above
- [ ] Commit your changes and start a pull request.
Comment From: Torres-09
Hi! If this issue is still open, I would like to work on it. Thanks!
Comment From: bclozel
I've assigned the issue to you @Torres-09 !
Comment From: bclozel
Superseded by #33766