You just received a pull request, so I changed the format similar to that.
- enhancement by adding early return
- delete the unnecessary 'else'
Comment From: KNU-K
Thank you for your review. I've finished working on the revers.
Comment From: KNU-K
@sbrannen I'm not used to contributing, but thank you for your meticulous review
Comment From: KNU-K
When I checked the report because the build didn't pass, there was an error in the "reactive" part. However, I didn't touch that part, and it's not where I corrected it that depends.
Comment From: sbrannen
When I checked the report because the build didn't pass, there was an error in the "reactive" part. However, I didn't touch that part, and it's not where I corrected it that depends.
Yep... WebClientIntegrationTests.applyAttributesToNativeRequest()
is a flaky test that's been failing quite a lot lately, and the team is looking into how to address that.
So, you can safely ignore those failures in the interim.
Comment From: KNU-K
Thank you for your good review of the long work :) Have a nice day today.
Comment From: sbrannen
This has been merged into 6.2.x
and main
in 2494ecb47bedb9c82c2a4c906005eb1cff8d5c22.
After merging, I noticed the copyright headers had not been updated, so I did that in 7f7819329c952a98a6e4ed81d376b5e8ca610e79.
Thanks for the PR and for making all of the requested changes.