Change the description for the uri client request observation metric to clarify that only the protocol, host and port parts are removed from the template with the default observability convention.
Adds tests to illustrate that it is intentional that the query parameters are kept as part of the template.
closes #34107
Comment From: pivotal-cla
@Mattias-Sehlstedt Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: bclozel
Thanks for your PR! Just realized that you didn't sign the CLA yet @Mattias-Sehlstedt, I'll put this issue back in triage until this is done.
Comment From: Mattias-Sehlstedt
I keep getting "Reauthorization required" when trying to sign the agreement, and I cannot see it as a know issue on the pivotal page (https://cla.pivotal.io/about). I have tried revoking the access and then enabling it again but the issue persists. Could this be considered an "Obvious fix", or should I be in contact with Pivotal and ask them about it?
Comment From: bclozel
Thanks for trying; I'll see what I can do.
In the meantime, if your contribution matches what the https://developercertificate.org/ says, you can force push your commit and signoff on it with git commit --signoff.
Comment From: pivotal-cla
@Mattias-Sehlstedt Thank you for signing the Contributor License Agreement!
Comment From: bclozel
Thanks @Mattias-Sehlstedt for your contribution! FYI we're moving away from the CLA and using signoffs now so this should avoid such problems in the future.
Comment From: Mattias-Sehlstedt
Thanks for the quick feedback and assistance @bclozel, makes it a very pleasant experience to contribute to open source 👍