Thank you for taking time to contribute this pull request! You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

Comment From: markpollack

Thanks, will review!

Comment From: honnuanand

@markpollack, please comment on my suggestion of moving to the latest version of the SDK and also using the relevant objects there.

Comment From: jogueber

Updated the SDK version. @honnuanand :)

Comment From: jogueber

For some reason, the version on the Pom file still shows.

2.20.157.

sorry my bad should be good now

Comment From: jogueber

@honnuanand can we merge this?

Comment From: markpollack

Let me see how I can get an environment up to verify the PR. Much thanks @jogueber

Comment From: honnuanand

I don't have permission to merge. I can try to set up an environment too. Thanks Anand

Sent via Superhuman @.***>

On Thu, Nov 09, 2023 at 12:46 PM, Mark Pollack @.***> wrote:

Let me see how I can get an environment up to verify the PR. Much thanks @ jogueber https://github.com/jogueber

— Reply to this email directly, view it on GitHub https://github.com/spring-projects-experimental/spring-ai/pull/67#issuecomment-1804662122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARSRQWL6IF7DJSKR5T3RCTYDU6L7AVCNFSM6AAAAAA6WBVFHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGY3DEMJSGI . You are receiving this because you were mentioned.Message ID: @.***>

Comment From: jogueber

Thanks @markpollack had some time to add more testing and models. Ping me if you have any questions!

Comment From: markpollack

I'm not sure how to merge this because it is hard to rebase given the Merge branch 'main' into aws-bedrock-support.

Is there a way you can get the overall diff between this branch and main and make another PR so that we can follow the git workflow i'm most used to. I'm open to other suggestions on how to merge this, my git-fu isn't great. We could also setup a zoom call. I don't want to cut-n-paste it so that you retain commit credits.

Again, thanks for the follow up, much appreciated.

Comment From: jogueber

Sure @markpollack I can also open up a new branch. Or we set up a quick Zoom call in the coming days. I'm in the European Time Zone and rather flexible :)

Comment From: markpollack

Let's arrange a zoom. Christian would be an easier contact to coordinate. Please reach out to me via email mpollack@ware.com and ctzolov@ware.com

Comment From: tzolov

Hi @jogueber
The https://github.com/spring-projects/spring-ai/pull/174 supersedes this PR by providing a more generic coverage of the various Chat and Embedding models provided by Bedrock. Once #174 is merged it will bring support for Bedrock: Llama2 Chat, Cohere Chat, Cohere Embedding, Anthropic Chat. It also provides the implementations of the basic TitanChatBedrockApi, TitanEmbeddingBedrockApi and Ai21Jurassic2ChatBedrockApi API clients that should be used to implement the Ai21 Jurassic2 and Titan's AiClient, AiStreamingClient , EmbeddingClient.

Let me know if you would be interested in implementing the Titan AiClient, AiStreamingClient , EmbeddingClient based on the TitanChatBedrockApi, TitanEmbeddingBedrockApi?

Comment From: tzolov

Close as resolved by 88869f10fa54f7ef8b2f0e3135a2acd60477ce70 and 26b1ccdc5768257a0d5feb9243fbee063dd3267f @jogueber if interested you still can contribute to the incomplete Bedrock Ai21 Jurassic2 model