First, apologies for the confusion earlier. With this commit, the end result should be:
- Per request appId setting is removed, due to it being handled better at client level
- Client-level appId setting is established for better visibility for Spring AI-based applications
- General cleanup of imports, etc.
- Minor fix to incorrect method call in docs, etc.
Please let me know if you have any questions, comments, or feedback. It's been a morning.
Comment From: tzolov
Thanks @mkheck , I will review it shortly. One general observation about spring code style:
Wildcard imports such as import java.util. or import static org.assertj.core.api.Assertions. are forbidden, even in test code.
Comment From: mkheck
Understood. Let me know if you want me to resolve that, happy to adjust. Cheers!
Comment From: markpollack
I'm getting merge errors related to vectordb documentation for azure and neo4j, which is unrelated to what you submitted. Can you perhaps make a new PR with a single commit of all your changes?
Comment From: mkheck
Hi @markpollack, this is what I'm seeing:
Please advise how you would like me to proceed. The docs you mention were in a previous approved PR. If you have a "shortest path" you'd recommend to get this last commit (dde4f630e4e71ddcbbf1fd14729fc0efec048fd5) from my repo in there, I'm open. If not, I can start fresh. Thanks.