Thank you for taking time to contribute this pull request! You might have already read the [contributor guide][1], but as a reminder, please make sure to:
- Sign the contributor license agreement
- Rebase your changes on the latest
main
branch and squash your commits - Add/Update unit tests as needed
- Run a build and make sure all tests pass prior to submission
Comment From: geetrawat
I also puzzled by the following the GemFireVectorStore code:
- The
GemFireVectorStore#topK
is not used.- The
GemFireVectorStore#GemFireVectorStoreConfigBuilder#connectionTimeout
,GemFireVectorStore#GemFireVectorStoreConfigBuilder#requestTimeout
are never used.- None of the
CreateRequest
setters is ever used? Actually none of the fields is every used. And given that this is a privet class, what is the purpose of adding those fields?
removed the connectionTimeout and requestTimeout and utilized other properties.
Comment From: geetrawat
We are creating a new improved PR.