Thank you for taking time to contribute this pull request! You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

Comment From: markpollack

merged in 40eaa9974e2ca84763e7eb9032392c241a6145a2

will create an issue to discuss how 'common options' are not getting i'll defined.

Comment From: dafriz

Note that the commit that got merged has the wrong values - https://github.com/spring-projects/spring-ai/commit/40eaa9974e2ca84763e7eb9032392c241a6145a2 . It was his follow up commit that had the names that match OpenAI docs - https://github.com/spring-projects/spring-ai/pull/1361/commits/0bd27e4dc9a2259802fd40c4c5b68a812f999dd7

See https://platform.openai.com/docs/models/o1 - they start with o1, not gpt.

Comment From: markpollack

ah, I got confused. I haven't yet played with the model myself. Thanks for that.

Comment From: markpollack

I've updated the enums to be

```

    /**
     * Points to the most recent snapshot of the o1 model:o1-preview-2024-09-12
     */
    O1_PREVIEW("o1-preview"),
    /**
     * Latest o1 model snapshot
     */
    O1_PREVIEW_2024_09_12("o1-preview-2024-09-12"),
    /**
     * Points to the most recent o1-mini snapshot:o1-mini-2024-09-12
     */
    O1_MINI("o1-mini"),
    /**
     * Latest o1-mini model snapshot
     */
    O1_MINI_2024_09_12("o1-mini-2024-09-12")

Comment From: markpollack

closing this PR and created #1378 for deeper analysis of rationalizing chatoptions, in particular due to how different the o1 model is regarding options and also functionality (e.g. no system messages)