- Add comment in MessageType for readability
- fix enum comment grammar
resolved #972
Comment From: tzolov
Thank you for the improvement @devholic22
Could you please resolve the formatting issue by running the ./mvnw spring-javaformat:apply javadoc:javadoc -Pjavadoc and then squash the 3 commits.
Comment From: devholic22
Thank you for the improvement @devholic22 Could you please resolve the formatting issue by running the
./mvnw spring-javaformat:apply javadoc:javadoc -Pjavadocand then squash the 3 commits.
Thanks for your advice. But even if I keep running the commands you mentioned, I won't get a file that changes. Is there any other way? If there is, I will apply it right away.
Actually, the second commit also applied ./mvnw spring-javaformat:apply.
there is my git status after your command apply.
Comment From: devholic22
@tzolov The cause code is MongoDBAtlasFilterExpressionConverter. I fixed this class comment :)
Comment From: tzolov
yeh, sorry. i've fixed the other error in https://github.com/spring-projects/spring-ai/commit/c09286eedfff170c733c9ed3398f08d87dcdc7ba
Could you please rebase your branch, please use git pull -r upstream main not merge, resolve the eventual conflicts and squash the result into a single commit.
Comment From: devholic22
Did I correct it well as you intended? I would appreciate it if you could check it :)
and if you have time, please review another my Pull Request about Audio model. thanks!
Comment From: tzolov
I still can see 2 commits? Did you squashed all commits?
Comment From: devholic22
I still can see 2 commits? Did you squashed all commits?
I squashed my commits using git rebase command :)
Comment From: markpollack
There are still 4 commits in this PR. I suggest you make a new PR with one commit that contains the changes you made the the file.
Comment From: devholic22
There are still 4 commits in this PR. I suggest you make a new PR with one commit that contains the changes you made the the file.
I understand. you can check in new PR.
Next time, I will squash the commits as you say. I'm sorry for the inconvenience.
Comment From: ThomasVitale
@devholic22 can this PR be closed since the change has been delivered via https://github.com/spring-projects/spring-ai/pull/1000?